websnacksjs/websnacks
1
0
Fork 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity Actions

Merge pull request #6 from websnacksjs/fix/render-numbers

Browse source 
fix: support number elements in jsx templates
This commit is contained in:
M. George Hansen 2020-06-02 15:45:39 -07:00
commit 2b60c35ae2
3 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/component.ts
View file

@ -25,7 +25,13 @@ export interface HTMLElement {
/** /**
* All valid types of elements that can be rendered to HTML. * All valid types of elements that can be rendered to HTML.
*/ */
export type Element = HTMLElement | string | boolean | undefined | null; export type Element =
| HTMLElement
| string
| number
| boolean
| undefined
| null;
/** /**
* Custom HTMLElement factory that can be parameterized by props. * Custom HTMLElement factory that can be parameterized by props.

3
src/render.ts
View file

@ -22,6 +22,9 @@ const renderElement = (elem: Element): string => {
if (elem == null || typeof elem === "boolean") { if (elem == null || typeof elem === "boolean") {
return ""; return "";
} }
if (typeof elem === "number") {
return elem.toString();
}
if (typeof elem === "string") { if (typeof elem === "string") {
return escapeHtml(elem); return escapeHtml(elem);
} }

6
test/test-suites/rendering.tsx
View file

@ -61,4 +61,10 @@ testSuite("renderPage", ({ test, expect }) => {
"<!DOCTYPE html><html>There are three lights!</html>" "<!DOCTYPE html><html>There are three lights!</html>"
); );
}); });
test("renders spliced number nodes", () => {
const nLights = 3;
const html = renderPage(<html>There are {nLights} lights!</html>);
expect(html).toEqual("<!DOCTYPE html><html>There are 3 lights!</html>");
});
}); });