websnacksjs/websnacks
1
0
Fork 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity Actions

fix: dev cmd didn't watch files due to import mangling

Browse source 
Appearently the esModuleInterop flag in TypeScript is not compatible
with node-watch, and the import helper was mangling the import as a
result and causing an error in the dev command that resulted in files
not being watched.

This fixes that import issue and adds an e2e test to help prevent a
regression of this issue in the future.
This commit is contained in:
M. George Hansen 2020-06-09 13:56:11 -07:00
parent af44f1ebf2
commit b559d5e21a
Signed by: mgeorgehansen
SSH key fingerprint: SHA256:JlIGiQLPyQ2RHTH3a2oVlb20Xkh9Glr8DUF4YTXHJxM
7 changed files with 200 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/cli/commands/dev.ts
View file

@ -182,8 +182,8 @@ const watchFolders = async (
// Try to load node-watch, falling back to fs watch if node-watch isn't
// available.
try {
const { default: watch } = await import("node-watch");
watch(folders, { recursive: true }, listener);
const nodeWatch = await import("node-watch");
nodeWatch.default(folders, { recursive: true }, listener);
return;
} catch (error) {
if (error.code !== "MODULE_NOT_FOUND") {